Conversation
bgavrilMS
approved these changes
Apr 29, 2026
gladjohn
approved these changes
Apr 29, 2026
This was referenced Apr 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API File Cleanup
Reduce developer toil by removing internal API files, documenting methods which are used cross-project, and reduce API file duplication.
Description
This removes the InternalAPI tracking files from nearly all projects and consolidates per-target-framework PublicAPI folder layouts into a smaller, shared structure. There is no functional change to any code files, this is purely to the tracking files (and a few comments).
Motivation
The Microsoft.CodeAnalysis.PublicApiAnalyzers "internal API" tracking (RS0051–RS0058) was producing significant
maintenance overhead:
In addition, the Per-TFM folders for Public API duplicated nearly identical content and required careful editing of each with each new member.
Changes
.editorconfig
Internal API Files
Removed all Internal API files with the sole exception of Microsoft.Identity.Web.Diagnostics, as that project is entirely internal and intended to be used by other Microsoft.Identity.Web.* projects.
Public API Files
Projects that can use a single set of Public API files:
Projects that need different files for NetCore and NetFramework:
The only special case is Microsoft.Identity.Web, which has some members which are only available for .net8 and .net9. That is handled with a special "NetCore_Pre10" folder. This assembly does not support NetFramework, so it still only has two folders (NetCore and NetCore_Pre10).
Internal API Usage Comments
Added comments to each internal member which has legitimate usage in other Microsoft.Identity.Web Non-Test assemblies, with a listing of which assemblies use them and a warning to not modify the members.
The majority of these comments are on Microsoft.Identity.Web.TokenAcquisition.
Impact
place, and the RS0016/RS0017 analyzers continue to enforce them.